webui: introduce confirmation dialog on rerun and cancel job actions#951
webui: introduce confirmation dialog on rerun and cancel job actions#951
Conversation
352033b to
c0141fa
Compare
pstorz
left a comment
There was a problem hiding this comment.
The "Dustbin" icon is not very good for cancelling the job. I would expect a red x or something like that, as the dustbin is associated with "deleting" somethin, not cancelling.
Other than that: good work!
c0141fa to
c041741
Compare
I agree, also it should be consistent in every place of the interface and we already used the glyphicon-remove (x) for a job cancel action on the dashboard. I changed it from glyphicon-trash (trashbin) to glyphicon-remove (x) in a separate commit. |
There was a problem hiding this comment.
Sorry, I was a bit too fast. Looking at jenkins and running the webui tests myself, it looks like some tests are now failing:
208 - webui:admin-rerun_job (Failed)
209 - webui:admin-restore (Failed)
213 - webui:readonly-rerun_job (Failed)
208: selenium.common.exceptions.UnexpectedAlertPresentException: Alert Text: None
208: Message: unexpected alert open: {Alert text : Rerun Job ID 1?}
|
Dang! Of course there are some adjustments required so the selenium tests can handle the changes. I'll adjust that so the tests work again. |
This commit extends the test_rerun_job method to accept the newly introduced confirmation dialog on rerun job action.
fa1229d to
3ffa44e
Compare
pstorz
left a comment
There was a problem hiding this comment.
Good work, the tests now pass.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing