Skip to content

build: keep only postgresql as supported database backend#949

Merged
arogge merged 25 commits intomasterfrom
dev/pstorz/master/postgresdb-only
Dec 10, 2021
Merged

build: keep only postgresql as supported database backend#949
arogge merged 25 commits intomasterfrom
dev/pstorz/master/postgresdb-only

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Oct 1, 2021

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@pstorz pstorz marked this pull request as draft October 1, 2021 16:08
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start.
Changes to the documentation are still needed.

@pstorz pstorz force-pushed the dev/pstorz/master/postgresdb-only branch from 772e0f2 to e4e1f5d Compare October 8, 2021 13:27
@pstorz pstorz self-assigned this Nov 4, 2021
@pstorz pstorz force-pushed the dev/pstorz/master/postgresdb-only branch 2 times, most recently from 920d028 to eb1c2e9 Compare November 19, 2021 20:47
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable.
However, we will have to update the documentation to reflect these changes.

@arogge arogge force-pushed the dev/pstorz/master/postgresdb-only branch 2 times, most recently from 9425e51 to a1a78c7 Compare November 22, 2021 19:10
Copy link
Member Author

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments

@arogge arogge force-pushed the dev/pstorz/master/postgresdb-only branch from 6a6a94d to 2b32765 Compare November 23, 2021 16:49
Copy link
Member Author

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small proposals for changes.

@arogge arogge force-pushed the dev/pstorz/master/postgresdb-only branch 3 times, most recently from 07a7e31 to 8d42626 Compare December 2, 2021 09:44
@arogge arogge force-pushed the dev/pstorz/master/postgresdb-only branch from 8d42626 to 98634f3 Compare December 10, 2021 10:46
Previously linking to bareossql also required linking to
bareoscats-postgresql which was not nice and error prone.
This patch hides bareoscats-postgresql as a public requirement for
bareossql making linking implicit and easy.
PostgreSQL is the only option, no need to configure that anymore.
previously you needed to configure the catalog database type for bscan
and dbcheck with an option. This is now set to PostgreSQL and the option
is ignored for backwards compatibility.
This patch links libbareoscats-postgresql with libbareos, so even the
windows linker will find all function entrypoints.
bareoscats was removed, because only bareoscats-postgresql was left and
the need for the stub backend is gone.
However, bareoscats-postgresql depends on bareossql and vice versa, so
that these modules would have to be merged into one. This patch
re-introduces bareoscats so we can avoid the dependency cycle and
postpone the merge of the two modules.
This patch removes all mentionings of MySQL and SQLite catalogs from the
documentation, leaving PostgreSQL as the only option.
@arogge arogge force-pushed the dev/pstorz/master/postgresdb-only branch from 98634f3 to 43b050e Compare December 10, 2021 11:36
@arogge arogge marked this pull request as ready for review December 10, 2021 11:37
@arogge arogge merged commit 3d56031 into master Dec 10, 2021
@arogge arogge deleted the dev/pstorz/master/postgresdb-only branch December 10, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants