build: keep only postgresql as supported database backend#949
Merged
build: keep only postgresql as supported database backend#949
Conversation
arogge
reviewed
Oct 7, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Looks like a good start.
Changes to the documentation are still needed.
772e0f2 to
e4e1f5d
Compare
920d028 to
eb1c2e9
Compare
arogge
reviewed
Nov 22, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
This looks reasonable.
However, we will have to update the documentation to reflect these changes.
9425e51 to
a1a78c7
Compare
pstorz
commented
Nov 23, 2021
Member
Author
pstorz
left a comment
There was a problem hiding this comment.
Just some small comments
6a6a94d to
2b32765
Compare
pstorz
commented
Nov 30, 2021
Member
Author
pstorz
left a comment
There was a problem hiding this comment.
Just some small proposals for changes.
07a7e31 to
8d42626
Compare
8d42626 to
98634f3
Compare
Previously linking to bareossql also required linking to bareoscats-postgresql which was not nice and error prone. This patch hides bareoscats-postgresql as a public requirement for bareossql making linking implicit and easy.
PostgreSQL is the only option, no need to configure that anymore.
previously you needed to configure the catalog database type for bscan and dbcheck with an option. This is now set to PostgreSQL and the option is ignored for backwards compatibility.
This patch links libbareoscats-postgresql with libbareos, so even the windows linker will find all function entrypoints.
bareoscats was removed, because only bareoscats-postgresql was left and the need for the stub backend is gone. However, bareoscats-postgresql depends on bareossql and vice versa, so that these modules would have to be merged into one. This patch re-introduces bareoscats so we can avoid the dependency cycle and postpone the merge of the two modules.
This patch removes all mentionings of MySQL and SQLite catalogs from the documentation, leaving PostgreSQL as the only option.
98634f3 to
43b050e
Compare
arogge
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing