webui: change retention/expiration column on volume tables to only show retention#943
Merged
webui: change retention/expiration column on volume tables to only show retention#943
Conversation
pstorz
requested changes
Oct 6, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
The CHANGELOG.md entry was a bit too short in my view. Other than that, good work.
38337a1 to
ca7dafc
Compare
pstorz
approved these changes
Oct 7, 2021
This commit is the first step of splitting the 'retention/expiration' column on volume tables into separate columns. An additional column will be introduced on volume tables later after delivery of expiration values in JSON API mode has been implemented. The commit also removes unnecessary formatter functions that are no longer required. Fixes #816: Incorrect display value of the item Retention/Expiration depending on the selected localization
ca7dafc to
7d4389c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the first step of splitting the 'retention/expiration'
column on volume tables into separate columns.
An additional column will be introduced on volume tables later
after delivery of expiration values in JSON API mode has been
implemented.
The commit also removes unnecessary formatter functions that are no
longer required.
Fixes #816: Incorrect display value of the item Retention/Expiration depending on the selected localization
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing