core: Remove deprecated configuration options#938
Merged
arogge merged 18 commits intobareos:masterfrom Sep 30, 2021
Merged
Conversation
pstorz
requested changes
Sep 28, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Very good work, it is great to see so much deprecated code go.
I have the following comments and wishes:
- The fixup of the Max Volume Size change should be merged into the correspoding commit
- The CHANGELOG.md commit does not exist
- It would make sense to document which deprecated configuration directives have been removed.(Breaking changes section in release notes?)
- bareos-check-sources is not happy with multiple files, please fix:
-
- Plugin 'clang-format check' would modify 'core/src/dird/backup.cc'
-
- Plugin 'fix copyright year' would modify 'core/src/dird/backup.cc'
-
- Plugin 'clang-format check' would modify 'core/src/dird/dird_conf.h'
-
- Plugin 'fix copyright year' would modify 'core/src/dird/next_vol.cc'
-
- Plugin 'fix copyright year' would modify 'core/src/dird/restore.cc'
-
- Plugin 'fix copyright year' would modify 'core/src/dird/ua_db.cc'
-
- Plugin 'fix copyright year' would modify 'core/src/dird/ua_dotcmds.cc'
-
- Plugin 'fix copyright year' would modify 'core/src/dird/verify.cc'
-
- Plugin 'clang-format check' would modify 'core/src/stored/device_resource.h'
415cd12 to
232d437
Compare
Member
Author
|
I think I fixed everything and also removed the documentation addon-files for the now removed directives |
3c44a96 to
8d99cfb
Compare
Adapt the system:config-dump test to the removed configuration directives.
e6b2265 to
d84f578
Compare
d84f578 to
e2f5c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all deprecated configuration options and their related code.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing