webui: improve log message keyword highlighting#937
Merged
Conversation
6a6e886 to
5fa7ec5
Compare
pstorz
requested changes
Oct 6, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
The danger_keywords now are also matched without word borders, whch means that
override is marked as ovride. It would be great if the keywords would be matched
with word borders.
Highlight the additional keywords "Cannot" and "ERR" in Log messages.
db157f3 to
7d0da52
Compare
Contributor
Author
|
Word boundaries added. |
pstorz
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlight the additional keywords "Cannot" and "ERR" in Log messages.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing