docs: document critical items with new systemd service type#927
Merged
pstorz merged 2 commits intobareos:masterfrom Sep 23, 2021
bruno-at-bareos:dev/bruno-at-bareos/documentation_critical_items_systemd
Merged
docs: document critical items with new systemd service type#927pstorz merged 2 commits intobareos:masterfrom bruno-at-bareos:dev/bruno-at-bareos/documentation_critical_items_systemd
pstorz merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno-at-bareos/documentation_critical_items_systemd
Conversation
pstorz
requested changes
Sep 17, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work, but
- Please add the CHANGELOG.md change in a single commit
- Add the PR Number to the CHANGELOG.md change
- Follow the commit formatting rules described here: https://docs.bareos.org/DeveloperGuide/gitworkflow.html#commits
pstorz
approved these changes
Sep 23, 2021
…rmation into systemd-journal Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add the discussed remark into the documentations.
closing task #4969
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General