Merged
Conversation
5e5c692 to
db9a227
Compare
arogge
requested changes
Sep 24, 2021
db9a227 to
8089278
Compare
arogge
reviewed
Sep 27, 2021
f9c3edd to
1d17b05
Compare
1d17b05 to
7e625cf
Compare
arogge
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Often bareos users ask for a hint what hardware to use with Bareos. This PR adds a chapter to the documentation
that helps users to estimate what hardware is adequate for a certain amount of data.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Separate commit for this PR in the CHANGELOG.md, PR number referenced is sameSource code quality
Source code changes are understandableVariable and function names are meaningfulCode comments are correct (logically and spelling)bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing