Skip to content

webui: set some options on chromedriver#920

Merged
arogge merged 2 commits intomasterfrom
dev/arogge/master/chromedriver-options
Sep 10, 2021
Merged

webui: set some options on chromedriver#920
arogge merged 2 commits intomasterfrom
dev/arogge/master/chromedriver-options

Conversation

@arogge
Copy link
Member

@arogge arogge commented Sep 9, 2021

This PR adds some common options to the chromedriver that should fix a sporadic issue with timeouts when running in our Jenkins testsuite

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one line to the CHANGELOG.md file.

@arogge arogge force-pushed the dev/arogge/master/chromedriver-options branch from 7453bb1 to 3ae3d3d Compare September 10, 2021 08:47
@arogge arogge merged commit 8dbeb36 into master Sep 10, 2021
@arogge arogge deleted the dev/arogge/master/chromedriver-options branch September 10, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants