update slots command crashes director when device or autochanger disappears#919
Merged
arogge merged 2 commits intobareos:masterfrom Sep 9, 2021
Conversation
added 2 commits
September 8, 2021 11:25
When in the while loop, the `vl` variable gets allocated some memory AFTER the fields check, and then this memory gets freed later in the loop. But when there is an iteration that stops at the check and gets redirected to `parse_error`, it has to free memory that was already freed in a previous iteration of the loop, which creates a double free situation that crashes the director.
Member
|
Do you think you could implement a unit-test for that and do you think it is worth the effort? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When there is an issue communicating with an autochanger or tape device, the director could crash when executing an
update slotscommand in bconsole. This PR fixes the issue.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing