Conversation
36d9173 to
4a4f559
Compare
arogge
left a comment
There was a problem hiding this comment.
We seem to have to remove dh-python as it conflicts with python-is-python2 and python-is-python3. However, I believe the real fix for this is not to use a versionless-python anymore.
We can probably require python2-dev and python3-dev for Bareos itself and dh-python for python-bareos resulting in clean dependencies.
AFAICT the only uses of a plain python are in python-bareos/setup.py and core/cmake/get_python_compile_settings.py - which seems to be easily fixable.
debian/control.in
Outdated
| pkg-config, | ||
| po-debconf (>= 0.8.2), | ||
| python-dev, | ||
| # python-dev, |
There was a problem hiding this comment.
isn't there a useful replacement for this? Maybe python-dev-is-python3 (or python-dev-is-python2).
There was a problem hiding this comment.
The bug that required this change is here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972726
debian/control.in
Outdated
| librados-dev <buster> <stretch> <xenial> <bionic>, | ||
| libradosstriper-dev <buster> <stretch> <xenial> <bionic>, | ||
| libcephfs-dev <buster> <stretch> <xenial> <bionic>, |
There was a problem hiding this comment.
these conditionals will need to have <bullseye> added to work as expected for us
| # python-dev, | ||
| zlib1g-dev, | ||
| systemd, | ||
| dh-systemd, |
There was a problem hiding this comment.
maybe we should tag it with the versions where we want it like this:
dh-systemd <buster> <stretch> <xenial> <bionic>,
This way at least our own builds will require it for these older releases.
|
Are there any plans by when the packages for Debian 11 will be ready? |
arogge
left a comment
There was a problem hiding this comment.
You need to add a record to the CHANGELOG, but otherwise it looks fine!
e7adb4c to
08b27cd
Compare
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests
Decision taken that a system- or unittest is required (if not, then remove this paragraph)The decision towards a systemtest is reasonable compared to a unittestTestname matches exactly what is being testedOutput of the test leads quickly to the origin of the fault