Merged
Conversation
arogge
reviewed
Sep 24, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Good improvement, especially as this remove a lot of really ugly #ifdef.
3c40e06 to
36991fa
Compare
As all supported operating systems support IPv6, we remove support for OS that do not support IPv6. - removed macro "HAVE_IPV6" - removed all code that is built when "HAVE_IPV6" is undefined - removed cmake switch "ipv6"
1f9ce67 to
d9dc247
Compare
arogge
approved these changes
Sep 28, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
I removed yet another #ifdef that was introduced by another PR and applied fixes from bareos-check-sources.
From my POV this can be merged now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
The bareos code was still able to be compiled for an OS that has no support vor IPv6.
As today all supported OS have support for IPv6, this code is removed with this PR.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing