fix system:bareos test on btrfs filesystems#907
Merged
pstorz merged 2 commits intobareos:masterfrom Aug 19, 2021
Merged
Conversation
fstype = btrfs to fileset
pstorz
requested changes
Aug 10, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work.
However, please adapt the commit messages to comply with the format described here:
https://docs.bareos.org/DeveloperGuide/gitworkflow.html#commits
Also, please add one line to the changelog like this: "systemtests: bareos test now also runs on btrfs filesystem"
Thank you very much.
85a3848 to
4180425
Compare
This commit adds `fstype = btrfs` to fileset in system:bareos.
4180425 to
e154976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When compiling on a system that somehow uses
btrfs, thesystemtest:bareosfails to backup with the error found intmp/log1.outthat saysTop level directory "..../bareos/systemtests/tests/bareos/tmp/data" has unlisted fstype "btrfs"This can happen for example on a fresh default install of Fedora 34.
Adding
fstype = btrfsto thefilesetconfig file resolves this issue.Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General