Adding benchmarks for marking files in the restore browser#883
Conversation
arogge
left a comment
There was a problem hiding this comment.
The only to-be-discussed item is whether or not we want the benchmarks to run as tests. I believe it doesn't make sense. We should probably discuss this in one of the next devmeetings.
Other than that, this is awesome work. The CMake-Integration looks good, the code is clean and understandable, the benchmarks works flawlessly and proves that the algorithm scales nearly linearly, which is great.
I also really like the fantastic documentation you added.
btw. could you run devtools/bareos-check-sources --since=origin/master --modify on the branch, so the CMakeLists.txt is properly reformatted?
07c0a5e to
b2eec88
Compare
arogge
left a comment
There was a problem hiding this comment.
I have made some suggestions concerning CMake.
If there is an option to enable building the benchmarks, we can and should probably fail if that is enabled and the required libraries are not available.
As far as I can tell, the tests are not added as ctest tests anymore, so there is no easy way (other than the manual way described in your documentation) to run them right now.
cdd999c to
2b21820
Compare
arogge
left a comment
There was a problem hiding this comment.
Looks good to me.
Still needs an entry in CHANGELOG.md.
bareos-check-sources complained about the CMakeLists.txt formatting, so I pushed a commit that fixes it - you may want to merge that one into one of your commits.
it runs all the benchmarks available and creates a json file containing the results for each apply changes from bareos-check-sources
ec3c925 to
82cfc8d
Compare
Description
This pull request introduces Benchmarks for developers to test and benchmark certain parts of the code when modifying performance or time critical code.
This is done with the help of the Google Benchmark tool.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing