webui: check major version compatibility between webui and DIR#880
webui: check major version compatibility between webui and DIR#880
Conversation
joergsteffens
left a comment
There was a problem hiding this comment.
Do you really want to enforce exactly the same version? In my test environment this is some thing like $bareos_full_version = "21.0.0~pre612.1aceb0611.dirty.
Shouldn't it be sufficient to enforce the same major version? If the Director and the WebUI do run on different hosts, it might be difficult to keep them exacltly in sync.
In principal it should be sufficient enough to compare the major version, as we use semantic versioning, there should be no breaking changes between minor updates and patches. |
0591ae3 to
0123aeb
Compare
|
I have reduced the comparison to the major release version, as this is sufficient for the purpose. Thanks for the comment and suggestion, it also avoids hassle during development and testing. |
80be2af to
ad2c06e
Compare
joergsteffens
left a comment
There was a problem hiding this comment.
I approve this PR with the 2 additonal commits. A rebase is still required for resolving the CHANGELOG.
To ensure the installed WEBUI and DIR have the same version because of compatibility reasons, this commit introduces a version check at login time which provides an error message if versions do not match. Fixes #871: UI will not load complete
5d10333 to
d25d7ea
Compare
|
Rebased and cleaned up the PR, should be fine now. |
To ensure the installed WEBUI and DIR have the same version
because of compatibility reasons, this PR introduces a version
check at login time which provides an error message if versions
do not match. In addition the PR fixes an issue within the api check.
Fixes #871: UI will not load complete
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing