Introduce devtools/dist-tarball.sh, centralize cmake version-files#861
Merged
pstorz merged 4 commits intobareos:masterfrom Jul 2, 2021
Merged
Conversation
9bb0738 to
3da8e91
Compare
pstorz
reviewed
Jul 2, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good. I have these points:
- bareos-check-sources --since-merge complains in 5 files baout copyright year and copyright missing
- I am not sure if we want/need some documentation update?
- I changed the title of the PR, hopefully to the better.
- I found one trailing whitespace (as change suggestion)
- I thing it makes sense to add at least one line to the CHANGELOG.md
devtools/dist-tarball.sh
Outdated
| (echo -ne 'cmake/BareosVersion.cmake\0'; "$git" ls-files -z) | \ | ||
| "$sort" -u -z | \ | ||
| "$tar" "${args[@]}" -cf - --files-from - | \ | ||
| "$xz" -c -6 > "${archive_file}" |
Member
There was a problem hiding this comment.
Suggested change
| "$xz" -c -6 > "${archive_file}" | |
| "$xz" -c -6 > "${archive_file}" |
Previously version-handling was done in webui and core subdirectories, so we could build the subdirectories individually. As we don't support building subdirectories anymore, the cmake code duplicated in webui and core subdirectories is now merged into the toplevel cmake directory.
This patch adds a new devtool called dist-tarball.sh that creates a reproducible xz-compressed tarball from a cloned git repository.
3da8e91 to
95e6e72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to generate a xz-compressed tarball from a clone of the bareos repository. For a given commit and version (may depend on git tags) the same exact tarball will be created every time.
The PR also centralizes the previously scattered (i.e. in core and webui) version handling into the toplevel cmake directory.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing