Merge Windows Debug-Build into Release-Build#858
Merged
Conversation
pstorz
requested changes
Jun 22, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
The matrix.yml file is not correct.
| x86_64: | ||
| - bareos | ||
| - python-bareos | ||
| "4.4": |
Member
There was a problem hiding this comment.
I think here is something missing, probably
Univention:
5d17115 to
be0a736
Compare
pstorz
requested changes
Jun 22, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
I think it makes sense to add a line to the CHANGELOG that the two windows builds were merged and only one Installer is now available for windows 32 and for windows 64.
dd8bae4 to
b9c7755
Compare
Member
Author
|
I triple-checked that all distros are built, all files are still produced as desired (i.e. no webui tarballs) and added the CHANGELOG record you requested. |
pstorz
approved these changes
Jun 28, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work, looks good to me. You might want to squash the last two commits.
Previously there were two packages built, one contained the sourcecode and the other one didn't. Now we always add the sourcecode to the installer package, so people can decide at install-time if they want to install the sources or not.
9eca2b5 to
e7b5a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the difference between debug and release for Windows is the shipping of the sourcecode only, this PR merges both packages into one.
The Sourcecode is now an optional component that can be selected at install-time.
To reconfigure the builds, this PR also adds a .matrix.yml that will tell Jenkins to only do the release-builds in the future.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing