use correct type for drive-parameter in stored/dir_cmd.cc#850
Merged
arogge merged 3 commits intobareos:masterfrom Jun 15, 2021
Merged
use correct type for drive-parameter in stored/dir_cmd.cc#850arogge merged 3 commits intobareos:masterfrom
arogge merged 3 commits intobareos:masterfrom
Conversation
dir_cmd.cc uses scanf() to fill integers. As %hd is used, pointers to (short int)* was expected, but int* was passed. While this works on little endian, it breaks on big endian. This patch now uses short int where applicable.
previously the SYSTEMTEST_TIMEOUT was not passed correctly leading to systemtests with a timeout of 0 seconds.
pstorz
approved these changes
Jun 15, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good. I think we need backports to 20 and 19.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the drive-parameter in SD's director command parsing. This issue is only visible on big endian machines.
Please check
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests