Skip to content

Update gitignore list for build output#82

Closed
rivimey wants to merge 1 commit intobareos:masterfrom
rivimey:gitignore
Closed

Update gitignore list for build output#82
rivimey wants to merge 1 commit intobareos:masterfrom
rivimey:gitignore

Conversation

@rivimey
Copy link
Contributor

@rivimey rivimey commented Apr 16, 2018

No description provided.

@joergsteffens
Copy link
Member

While I understand and appreciate the intention of this change, I see a couple of problems.

  1. the wildcards would catch the following files, that are not created during build (no *.in file):
    debian/univention-bareos.preinst
    debian/univention-bareos.univention-service
    src/defaultconfigs/
    ./bareos-dir.d/fileset/Windows All Drives.conf
    ./bareos-dir.d/pool/Differential.conf
    ./bareos-dir.d/pool/Full.conf
    ./bareos-dir.d/pool/Incremental.conf
    ./bareos-dir.d/pool/Scratch.conf
    ./bareos-dir.d/profile/operator.conf
    ./bareos-dir.d/schedule/WeeklyCycle.conf
    ./bareos-dir.d/schedule/WeeklyCycleAfterBackup.conf
    ./bareos-fd.d/messages/Standard.conf
    ./bareos-sd.d/messages/Standard.conf
    ./d2d2t-disk-changer/disk-changer.conf

The FILENAME.in => FILENAME mechanism is only used, when the file contains a variable that must be replaced.

The problem can be solved by either use gitignore without wildcards or the rename these files to *.in.

  1. during the repository consolidation, these files will move to the core/ sub-directory. I propose to delay these, until the new repository is available.

@joergsteffens joergsteffens self-assigned this Jun 19, 2018
@joergsteffens
Copy link
Member

Any comments to my comment? If not, I prefer closing this ticket.

@joergsteffens
Copy link
Member

Closing this for now, until we find the time to find a proper solution.

@rivimey rivimey deleted the gitignore branch August 9, 2018 23:43
@tuxmaster5000 tuxmaster5000 mentioned this pull request Jul 6, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants