Skip to content

Fix bug-0001194: accurate incremental backup#810

Merged
pstorz merged 2 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/bug-0001194-incremental-backup
May 20, 2021
Merged

Fix bug-0001194: accurate incremental backup#810
pstorz merged 2 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/bug-0001194-incremental-backup

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented May 5, 2021

Thank you for contributing to the Bareos Project!

Description:

If an error happens while fetching files during an incremental backup job with the accurate option enabled, a full backup is done instead of aborting the job and reporting the error. This PR addresses the issue.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/bug-0001194-incremental-backup branch 4 times, most recently from 8c8eedf to 3fe5c67 Compare May 5, 2021 23:25
@pstorz pstorz self-assigned this May 6, 2021
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/bug-0001194-incremental-backup branch 2 times, most recently from 3cfeab6 to c9e33c6 Compare May 11, 2021 15:54
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/bug-0001194-incremental-backup branch from c9e33c6 to 36046a1 Compare May 14, 2021 10:45
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good work!

@pstorz pstorz changed the title bug-0001194 accurate incremental backup Fix bug-0001194: accurate incremental backup May 20, 2021
Added check for file list fetching in case of failure
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/bug-0001194-incremental-backup branch from 36046a1 to b68b1f1 Compare May 20, 2021 18:27
@pstorz pstorz merged commit c4d80cf into bareos:master May 20, 2021
@pstorz pstorz deleted the dev/alaaeddineelamri/master/bug-0001194-incremental-backup branch May 20, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants