Restore browser globbing bug with paths in mark command#801
Merged
arogge merged 3 commits intobareos:masterfrom May 27, 2021
Merged
Conversation
e6ae437 to
4e8e68d
Compare
a0e1a05 to
7e20c29
Compare
730b60f to
20f2c0a
Compare
af395dd to
54c6a40
Compare
- Changed the matching algorithm - Moved the marking and counting of the elements to its own function - Did some variable renaming and changed certain comments
- Had to recreate and fake the environment in which the `cd` and `mark` commands work in order to test them. - Initial file tree could be expanded
arogge
approved these changes
May 27, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Looks great. Works great.
bareos-check-sources fixed an indentation in a CMakeLists.txt and i rewrapped another commit comment. Other than that I resolved a conflict I just introduced by merging another PR.
However, we should probably add a benchmark for this in the future, as this is one of the few really performance-critical things that happens in the director. People casually load directory tree's with millions of files.
54c6a40 to
947d5d5
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Description:
In the restore browser, when a user wants to use wildcards within complex paths, files do not get marked consistently or paths are considered invalid. These changes address this issue by changing how the wildcard matching works within the mark command as well as introducing a unit test.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
Required documentation changes are present and part of the PRcheck-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests
The decision towards a systemtest is reasonable compared to a unittest