cmake: do not pollute sourcetree with untracked files#767
Merged
pstorz merged 3 commits intobareos:masterfrom Apr 16, 2021
Merged
cmake: do not pollute sourcetree with untracked files#767pstorz merged 3 commits intobareos:masterfrom
pstorz merged 3 commits intobareos:masterfrom
Conversation
pstorz
requested changes
Mar 22, 2021
9e113c9 to
cd9ff72
Compare
cf6f8b5 to
cd9ff72
Compare
previously two files showed up that were generated by cmake. This patch
adds the debian install-file to .gitignore and changes the global
configure_file not to pick up files from core/ but only from core/src
which will disable creation of CTestScript.cmake in core/ as it is
already generated to ${CMAKE_BINARY_DIR}/CTestScript.cmake
Previously core/ could be configured and built on its own. As this has become more and more of a maintenance burden, we disable support for that now.
7d53f6f to
cff044a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously two files showed up that were generated by cmake. This patch
adds the debian install-file to .gitignore and changes the global
configure_file not to pick up files from core/ but only from core/src
which will disable creation of CTestScript.cmake in core/ as it is
already generated to ${CMAKE_BINARY_DIR}/CTestScript.cmake
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing