Skip to content

systemtests: improve Bareos daemon control scripts#762

Merged
joergsteffens merged 3 commits intomasterfrom
dev/joergs/master/systemtest-control-scripts
Mar 9, 2021
Merged

systemtests: improve Bareos daemon control scripts#762
joergsteffens merged 3 commits intomasterfrom
dev/joergs/master/systemtest-control-scripts

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Mar 9, 2021

  • Fix behavior of "bareos-ctl-* status". Only check own process.
  • "bareos-ctl-* stop": output status. Wait up to 2 seconds, until process is really terminated.
  • "bareos-ctl-*": reduce differences between the scripts.
  • Cleanup.
  • systemtests: make PSCMD cmake variable available for systemtests

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

* Fix behavior of "bareos-ctl-* status". Only check own process.
* "bareos-ctl-* stop": output status. Wait up to 2 seconds, until process is really terminated.
* "bareos-ctl-*":  reduce differences between the scripts.
* Cleanup.
@joergsteffens joergsteffens requested a review from franku March 9, 2021 12:00
@joergsteffens joergsteffens mentioned this pull request Mar 9, 2021
16 tasks
@franku franku changed the title systemtests: improve Bareos daemin control scripts systemtests: improve Bareos daemon control scripts Mar 9, 2021
Copy link
Contributor

@franku franku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joergsteffens joergsteffens merged commit fbb77b0 into master Mar 9, 2021
@joergsteffens joergsteffens deleted the dev/joergs/master/systemtest-control-scripts branch March 9, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants