Skip to content

systemtests: fix volume-pruning test#761

Merged
pstorz merged 4 commits intomasterfrom
dev/pstorz/master/fix-volume-pruning-test
Mar 11, 2021
Merged

systemtests: fix volume-pruning test#761
pstorz merged 4 commits intomasterfrom
dev/pstorz/master/fix-volume-pruning-test

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Mar 8, 2021

Fix the volume-pruning system test that was unrelyable on some test platforms.
Now the test passes on all platforms that we build for.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@pstorz pstorz requested a review from franku March 9, 2021 09:41
@pstorz pstorz self-assigned this Mar 9, 2021
Copy link
Contributor

@franku franku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit 5a39e5d into master Mar 11, 2021
@pstorz pstorz deleted the dev/pstorz/master/fix-volume-pruning-test branch March 11, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants