disable recent job results list for sparc and improve test#757
Merged
disable recent job results list for sparc and improve test#757
Conversation
pstorz
requested changes
Mar 2, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
I would suggest to change the name of the tests:
recent_job_results_list -> statefile:
read_job_results_from_flie -> read
write_job_results_to_file -> write
read_job_results_from_file_truncated_jobs -> handle_truncated_jobs
read_job_results_from_file_truncated_header -> handle_truncated_headers
read_job_results_from_file_not_exist -> handle_empty_file
arogge
reviewed
Mar 2, 2021
9f24f0a to
972a0e3
Compare
- renamed unittest "recent_job_results_list" to "statefile"
cbcbd67 to
801dd19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Add some information
Keep spirit!