python-bareos: fallback to ssl.PROTOCOL_SSLv23#748
Merged
Conversation
40a8422 to
34e76dd
Compare
arogge
reviewed
Feb 25, 2021
34e76dd to
281c5b3
Compare
franku
suggested changes
Feb 25, 2021
Contributor
franku
left a comment
There was a problem hiding this comment.
Please remove the mentioned comments as they do not add an obvious information.
By default we set ssl.PROTOCOL_TLS. However, this requires Python >= 2.7.13, which is not available by default on RHEL/CentOS 7. Therefore we added a fallback to ssl.PROTOCOL_SSLv23.
281c5b3 to
a3897f5
Compare
franku
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default we set ssl.PROTOCOL_TLS.
However, this requires Python >= 2.7.13, which is not available by default on RHEL/CentOS 7.
Therefore we added a fallback to ssl.PROTOCOL_SSLv23.
This requires backports down to bareos-19.2.
Please follow these few prerequisites before you hand in a PR
Consider the following chapters in the Bareos Developer Documentation
Add some information
Keep spirit!