stored: use "archive_device_string" variable for archive device#744
Merged
stored: use "archive_device_string" variable for archive device#744
Conversation
07b84c9 to
9fa7144
Compare
5d0dbad to
20f390a
Compare
franku
approved these changes
Mar 11, 2021
Contributor
franku
left a comment
There was a problem hiding this comment.
Good idea to give a meaningful name..
However, please update the changelog.
a257a24 to
64f2b95
Compare
The "archive device" directive was stored in the variable "device_name" in the "DeviceResource" Class and in "dev_name" in the "Device" Class. This is misleading as the device name (i.e. the name of the device resource) is stored in the "resource_name_" member of the device resource.
64f2b95 to
e1bccb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "archive device" directive was stored in the variable "device_name"
in the "DeviceResource" Class and in "dev_name" in the "Device" Class.
This is misleading as the device name (i.e. the name of the device
resource) is stored in the "resource_name_" member of the device resource.
Please follow these few prerequisites before you hand in a PR
Consider the following chapters in the Bareos Developer Documentation
Add some information
Keep spirit!