Conversation
7585ae5 to
f540440
Compare
franku
approved these changes
Feb 16, 2021
Contributor
franku
left a comment
There was a problem hiding this comment.
You may want to add a line to the Fixed section in the changelog as proposed.
| ### Fixed | ||
| - fix parallel python plugin jobs [PR #732] | ||
| - fix oVirt plugin problem with config file [PR #732] | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| - fix crash when loading both python-fd and python3-fd plugins [PR #730] |
- Check if Py_IsInitialized() before initializing the plugin and skip double initialization. - unloadPlugin(): skip the Python shutdown so that a crash is avoided
This is the reason why the "plugin names" should always be specified.
48f1427 to
4c54502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow these few prerequisites before you hand in a PR
Consider the following chapters in the Bareos Developer Documentation
Add some information
Keep spirit!