Merged
Conversation
29af759 to
d29866b
Compare
b2b8d63 to
d95a2d5
Compare
3aa961b to
fd918c9
Compare
arogge
reviewed
Jan 28, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Thank you very much! This is amazing work.
Great implementation, nicely tested and well documented.
You should definitely add your name to the AUTHORS file!
I have some remarks and suggestions. Most of them are not too important, feel free to discuss.
228f1ca to
08dcd54
Compare
arogge
reviewed
Feb 1, 2021
08dcd54 to
3dad462
Compare
arogge
requested changes
Feb 4, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
I found a small problem that's left, otherwise it is really fine now.
82584da to
04ed914
Compare
04ed914 to
25bba18
Compare
franku
reviewed
Feb 15, 2021
franku
reviewed
Feb 15, 2021
06921bf to
bf2e3ec
Compare
1e0f612 to
73c1f7c
Compare
- User could enter wrong dates such as 1999-88-70 27:55:798, now he is denied - Trailing strings are now detected - Added tests for typical wrong entries
- User can now directly enter a short date such as 1999-05, and it will be compensated with the lowest remainder values possible to become a full date such as 1999-05-01 00:00:00 - added tests for different user date entries
73c1f7c to
b1faae6
Compare
arogge
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for shorter date formats, where shorter dates are compensated with lowest value possible to make a full date
also fix a bug where Bareos accepted bogus datetime formats.