Merged
Conversation
c3a733c to
5dc2f9f
Compare
887e1d6 to
1a633e6
Compare
Base automatically changed from
dev/franku/master/pre-check-hostname
to
master
January 13, 2021 22:36
aba130a to
5500349
Compare
- sometimes the python process library throws an invalid file descriptor exception during the start of worker processes when flushing stdout/stderr - with this fix stdout/stderr will be redirected to /dev/null so there is always a valid file descriptor
b8625e5 to
d098f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the invalid file descriptor issue in the libcloud plugin. Remark, there could be information about some other issue that will be lost when written to /dev/null.
Therefore we should decide if /dev/null is right or if we want to redirect to a regular file. The reason I ask is, the invalid filedescriptor error occurs randomly and only if there was a previous write to stdout just before the new process starts. This text could containt more information about any other issue we do not know yet.