Fix shebang error on rpmbuild by tuxmaster5000 · Pull Request #695 · bareos/bareos

tuxmaster5000 · 2020-12-21T06:06:41Z

When building the rpm package, many errors/warnings about an wrong shebang is shown.

arogge · 2021-01-14T16:21:11Z

There is a problem and I think your patch will fix it for RH/Fedora and probably also other Linuxes.
However, I'm quite sure #!/usr/bin/sh and #!/usr/bin/perl will break on at least one of the "classic" unix systems.

We will have to look into this a bit more.
What warnings does rpmbuild yield in your environment?

tuxmaster5000 · 2021-01-14T16:31:17Z

Hi Andreas,
I get many messages about "WARNING: mangling shebang" after the %file section is called.
It think it comes form this change in the RHEL/Fedora world:
https://pagure.io/packaging-committee/issue/738#comment-490366
It will happens on any bash and python scripts

arogge

Your changes make sense for Red Hat / Fedora, but they break portability. We can probably implement your changes in a system-specific way, but it will be a lot harder to do so.

arogge · 2021-01-25T09:54:26Z

core/platforms/redhat/bareos-dir.in

@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/usr/bin/sh


As we dropped support for RHEL6, we should probably remove the old initscripts instead of maintaining them further.
Could you remove these files and see if the build still works? They shouldn't be installed when building with systemd anyway.

arogge · 2021-01-25T09:54:33Z

core/platforms/redhat/bareos-fd.in

@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/usr/bin/sh


arogge · 2021-01-25T09:54:40Z

core/platforms/redhat/bareos-sd.in

@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/usr/bin/sh


arogge · 2021-01-25T09:55:58Z

core/scripts/bareos-config-lib.sh.in

@@ -1,3 +1,4 @@
+#!/usr/bin/sh


the resulting file should not be executable. So we shouldn't add a shebang, but remove exectuable permissions (this can be done somewhere in a CMakeLists.txt)

arogge · 2021-01-25T10:03:41Z

core/scripts/bareos-config.in

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/sh


Sorry, but /usr/bin/sh is Red Hat / Fedora specific. In POSIX the path to the standard shell is /bin/sh. This change would break everything, but Red Hat / Fedora.
You can provide a patch that applies this change for Fedora/Red Hat only or you can change the specfile to ignore silence the warning using __brp_mangle_shebangs_exclude.

arogge · 2021-01-25T10:04:52Z

core/src/cats/drop_bareos_tables.in

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/sh


arogge · 2021-01-25T10:04:56Z

core/src/cats/grant_bareos_privileges.in

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/sh


arogge · 2021-01-25T10:05:00Z

core/src/cats/make_bareos_tables.in

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/sh


arogge · 2021-01-25T10:05:05Z

core/src/cats/make_catalog_backup.in

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/sh


arogge · 2021-01-25T10:12:58Z

core/src/cats/make_catalog_backup.pl.in

@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl


you're not wrong, but we will have to support systems that have perl in unusual places (i.e. FreeBSD has it in /usr/local/bin/perl).
So far /usr/bin/env has worked well. We could change this, but we would have to configure the path system specific and detect the path to perl in CMake and set it using a variable.
If you propose a patch, I'll test and implement it.

Having said that, we're trying to remove/replace all perl scripts anyways, so I'm not really sure it is worth the effort anymore.

arogge · 2021-04-15T10:22:33Z

It's been three months without reply now. I close the PR.
Feel free to reopen if desired.

Fix shebang error on rpmbuild

c9bdd75

pstorz added the nobuild label Jan 19, 2021

franku assigned arogge Jan 21, 2021

arogge requested changes Jan 25, 2021

View reviewed changes

joergsteffens mentioned this pull request Jan 25, 2021

Remove unneeded X file rights #696

Merged

arogge closed this Apr 15, 2021

		@@ -1,4 +1,4 @@
		#!/bin/sh
		#!/usr/bin/sh

		@@ -1,4 +1,4 @@
		#!/bin/sh
		#!/usr/bin/sh

		@@ -1,4 +1,4 @@
		#!/bin/sh
		#!/usr/bin/sh

		@@ -1,4 +1,4 @@
		#!/bin/sh
		#!/usr/bin/sh

Conversation

tuxmaster5000 commented Dec 21, 2020

Uh oh!

arogge commented Jan 14, 2021

Uh oh!

tuxmaster5000 commented Jan 14, 2021

Uh oh!

arogge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arogge commented Apr 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants