Storage daemon DeviceResource: Set autoselect using a ui command#686
Merged
Storage daemon DeviceResource: Set autoselect using a ui command#686
Conversation
1d07192 to
a6416c0
Compare
pstorz
reviewed
Dec 8, 2020
d1fdc62 to
11100b7
Compare
pstorz
reviewed
Dec 14, 2020
Member
pstorz
left a comment
There was a problem hiding this comment.
I think it makes sense to talk about the introduction of exceptions.
pstorz
reviewed
Dec 14, 2020
d519127 to
5bf968a
Compare
arogge
reviewed
Dec 15, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
check-sources said: Plugin 'fix copyright year' would modify 'core/src/dird/ua_server.h'
I'll run the tests now.
arogge
reviewed
Dec 15, 2020
- moved class BoolString into a separate files - implemented unit tests
- rst documentation and CHANGELOG.md
applied check-sources script
180a96c to
9105010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the ui command:
setdevice storage=<storage-name> device=<device-name> autoselect=<bool>It will set the value of DeviceResource::autoselect to false or true, thus dis- or enabling an autochanger from automatically choosing a device during reservation.