initial checkin of experimental Bareos REST API#587
Merged
Conversation
a7c10e9 to
f0aa3a5
Compare
arogge
reviewed
Sep 15, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
- the
rest-api/main.pyis very large, maybe the model classes could be moved elsewhere or the functionality could be split up into separate files based on the subject - there is a lot of unused configuration files in the system test. Usually we try to reduce the configuration to what is really required.
- if I counted correctly there are 65 routes and the systemtest tests only two of them, that's about 3% test coverage
- you're using
curlin a shell-script for the test. As you're safe to assume that python is available, you might consider testing the API with a python program which will allow much more in-depth analysis of the results provided by the API - some of the REST routes don't "feel" right, but maybe that's just me
e5b7842 to
2ead174
Compare
3fe5035 to
e72005a
Compare
34a2fe5 to
e7308a2
Compare
e7308a2 to
1d67b13
Compare
Contributor
|
The README of this tech preview should be adapted to also address end users who want to try it out.
A link to the specific section in our developers guide where those informations are given might be sufficient. |
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Nov 30, 2020
frb121
reviewed
Dec 1, 2020
71a6863 to
594543e
Compare
frb121
approved these changes
Dec 1, 2020
Contributor
frb121
left a comment
There was a problem hiding this comment.
Looks good to me so far as a tech preview.
franku
suggested changes
Dec 2, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Huge amount of work! However I have some smaller issues:
- Please update the hyperlinks to documentation as suggested (some have errors)
- the build environment is currently located in the source tree but should be located in the build area
3bfb277 to
36b9dda
Compare
This is an experimental and preliminary backend for development purposes. The endpoints are subject for review and maybe changed in the future. It provides a REST API using fastapi, uvicorn and python-bareos to connect to a Bareos director. It supports the `configure add` commands to create configuration for clients, jobs, filesets and some more resources. It also provides endpoints to query job information and job control (i.e. start / restart jobs, trigger restores). Python3 is required to run the REST API.
36b9dda to
9a95f84
Compare
franku
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on fastapi / uvicorn and python-bareos
include systemtest with dependency on python3 modules fastapi and uvicorn