Merged
Conversation
The storage daemon's configuration parser now calls Validate() on each resource during pass 2.
As setting Maximum Block Size on a non-tape device can lead to unexpected results we now emit a warning in that case.
pstorz
requested changes
Sep 3, 2020
core/src/stored/stored.cc
Outdated
| ParseSdConfig(configfile, M_ERROR_TERM); | ||
|
|
||
| if (forge_on) { | ||
| my_config->AddWarning("Running with '-p' is for testing purposes only"); |
Member
There was a problem hiding this comment.
How about "for testing and emergency recovery purposes only"
|
|
||
| BareosResource* allocated_resource = *resources[rindex].allocated_resource_; | ||
| if (pass == 2 && !allocated_resource->Validate()) { | ||
| return false; |
Member
There was a problem hiding this comment.
Does this return value mean that the storage daemon does not start?
Member
Author
There was a problem hiding this comment.
Yes. If Validate() returns false, the the SD will not start. This is analogous to the behaviour of the Director.
The idea is that we can run in-depth checks of the configuration that way (which was why that function added to the director in the first place).
Previously, when running the storage daemon with '-p' there was no indication besides the actual commandline. We now register a configuration warning, so people can see that this is not fit for production.
5913a9d to
d5bc272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configuration warnings to the SD when
Maximum Block Sizeis configured on a device that is not a tape-pto ignore i/o errors