Extend bconsole show command to support JSON output format (API 2)#574
Merged
joergsteffens merged 6 commits intomasterfrom Aug 28, 2020
Merged
Extend bconsole show command to support JSON output format (API 2)#574joergsteffens merged 6 commits intomasterfrom
joergsteffens merged 6 commits intomasterfrom
Conversation
f461aad to
6d6df34
Compare
franku
reviewed
Aug 20, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Started with review mostly on semantic things with some suggestions and comments.
In my opinion the major work for switching void sendit into bool sendit could habe been avoided because all function-callbacks that are given to this argument always return true.
2c30471 to
e8b0659
Compare
The show command can print the configuration of the Bareos Director. To extend the functionality to also produce JSON output, the already existing OutputFormatter class is used. As the Bareos Daemons can all dump their configuration (in plain, none verbose mode), changes to all Daemons have been necessary.
Skip the test "test_json_backend_with_invalid_json_output", as most commands now produce valid JSON output. Add the test "PythonBareosShowTest.test_fileset" to check, if a fileset content is written correctly into the catalog. Add the test PythonBareosJsonConfigTest.test_show_command. Verifies that the "show" command delivers valid JSON.
This test checks if configuration data is written correctly by the "show" command. Checks both the modes: normal text, JSON.
e8b0659 to
3351e3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.