enable testing of deprecated databases (MySQL and SQLite)#573
Merged
Conversation
In order to still allow creation of MySQL and SQlite databases when running tests but forbid it otherwise, the environment variable BAREOS_TEST_RUNNING is defined in all tests. When this variable is undefined, creating databases and making tables of MySQL and SQLite is forbidden.
arogge
approved these changes
Aug 19, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
On one hand I'm not happy with BAREOS_TEST_RUNNING, but then again it makes absolutely sure that you should not set this value when installing.
Good idea overall. Probably best / simplest solution to work around our issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to create deprecated catalog databases was removed before. Unfortunately, we still need to be able to create those databases for our own tests.
This PR enables the creation of deprecated databases for only when running in our test environment. Otherwise, the creation will be denied like before.