Fix hearbeat thread shutdown race condition#565
Merged
Conversation
arogge
approved these changes
Aug 7, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
I'm not sure I understand the purpose 100%, but it looks good to me.
17fdd83 to
8980ca5
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix for the heartbeat shutdown where it could happen that the thread is already down but the stopping thread is still waiting for it to start. However this works the complete heartbeat code should be refactored again.
The fix uses a new variable that is only set if the thread has been started once.
Otherwise I left the code as much as before as I could.