Add deprecation notifications for catalogs using mysql/sqlite3#564
Merged
arogge merged 7 commits intobareos:masterfrom Aug 7, 2020
Merged
Add deprecation notifications for catalogs using mysql/sqlite3#564arogge merged 7 commits intobareos:masterfrom
arogge merged 7 commits intobareos:masterfrom
Conversation
Member
Author
|
I just realized there are two cleanup commits in the branch. Hope that doesn't hurt. |
f1551e4 to
cd908bc
Compare
* ignore files in the right location * only configure files in core and debian, but not systemtests/regress * add updated debian/control, so we don't see a change in git after configuring the project
Previously only JobResource had a method called Validate() to check the resource for completeness and correctness. This patch adds a virtual Validate() method to BareosResource that can be overridden by every resource that needs to do additional checks.
This patch adds a configuration warning when using one of the deprecated db drivers mysql or sqlite3.
When running with dbtype mysql or sqlite this test checks that the deprecation message is printed when calling bareos-dir -t.
Previously dbdriver was a required setting. As PostgreSQL is the only non-deprecated option right now, we set this as the default value.
e7569bc to
2a21c54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configuration warning for every catalog that uses DB driver mysql oder sqlite3.
To implement this a simple validation call-back was added to the director's configparser and every resource needing validation can just implement that.