Merged
Conversation
Contributor
franku
commented
Jul 23, 2020
- added CustomCallback to the bnet server that runs once a second
- the CustomCallback runs connection_pool->cleanup()
- cleanup() closes a socket as soon as it is not used anymore
73226a3 to
e58ce6c
Compare
arogge
approved these changes
Aug 7, 2020
b1a91d9 to
fd4a268
Compare
- added CustomCallback to the bnet server that runs once a second - the CustomCallback runs connection_pool->cleanup() - cleanup() closes a socket as soon as it is not used anymore
- remove unneeded functions - rename NULL by nullptr - cleanup the code partly
fd4a268 to
a03f7bb
Compare
- rename or remove confusing variables - move code into separate functions - set SO_REUSEADDR always on
- set SO_KEEPALIVE always on because nokeepalive was always false
3ee43dd to
321e436
Compare
Contributor
Author
|
Build succeeded with #28, should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.