build from source: fix "make install" and add "make uninstall"#556
Merged
build from source: fix "make install" and add "make uninstall"#556
Conversation
The "make install" target created by cmake was not completely working. Also, "make uninstall" was not available. This patch fixes the problems with the "make install" target and added the "make uninstall" target by reading the installed files from the cmake manifest file and deleting them. The code for the uninstall target was taken from: https://gist.github.com/royvandam/3033428
The default database driver is now got from the configured database options. To set the placeholder there, the default_db_backend cmake variable needs to be set during build via -Ddefault_db_backend="XXX_REPLACE_WITH_DATABASE_DRIVER_XXX"
franku
approved these changes
Jul 15, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
You may want to remove commented line.
Contributor
|
|
Co-authored-by: Frank Ueberschar <frank.ueberschar@bareos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building bareos from source, "make install" still had some problems which are solved now.
Also, "make uninstall" was added which removes the files that are listed in the cmake install "manifest" file.