allow backup/restore of cephfs mounts#554
Merged
arogge merged 5 commits intobareos:masterfrom Aug 26, 2020
Merged
Conversation
Member
Author
|
This patch works on linux, but doesn't compile on Solaris, FreeBSD and Windows. Will need (probably minor) work. |
franku
approved these changes
Aug 19, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Really good work, however I have two minor suggestions. Pls see the comments.
56295e0 to
7df1c22
Compare
Previously the filed did not pick up xattr on filesystems when st_dev == 0. This patch now also considers such filesystems. Additionally the virtual xattrs that cephfs provides were added to the blacklist for Linux, so we don't back them up (they cannot be written on restore, so backing them up is useless and restoring them will fail).
A simple test to check whether attributes set with setfattr are backed up and restored properly.
A simple test to check whether attributes set with setfacl are backed up and restored properly.
Previously the filed did not pick up acl on filesystems when st_dev == 0. This patch now also considers such filesystems.
7df1c22 to
297c8e7
Compare
Older CMake doesn't support file(TOUCH) yet, so we use file(WRITE) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filed did not pick up xattr on filesystems when st_dev == 0. This PR now also considers such filesystems. Additionally the virtual xattrs that cephfs provides were added to the blacklist for Linux.