Skip to content

dird: ignore duplicate job checking on virtual fulls started by consolidation#552

Merged
pstorz merged 4 commits intomasterfrom
dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai
Apr 26, 2021
Merged

dird: ignore duplicate job checking on virtual fulls started by consolidation#552
pstorz merged 4 commits intomasterfrom
dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Jul 6, 2020 •
edited by pstorz
Loading

  • Ignore AllowDuplicateJobs directive on generated virtual backup jobs by a consolidate job
  • The test checks if we end up with a canceled virtual full after consolidation. The test fails if the virtual full is canceled.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch 2 times, most recently from f2a7de6 to 08d6e08 Compare July 7, 2020 11:00
@frb121 frb121 marked this pull request as ready for review July 7, 2020 11:02
@frb121 frb121 requested a review from pstorz July 7, 2020 11:08
@frb121 frb121 marked this pull request as draft July 8, 2020 11:08
@frb121 frb121 removed the request for review from pstorz July 9, 2020 10:49
@frb121 frb121 added the onhold label Jul 9, 2020
@pstorz pstorz added the nobuild label Apr 6, 2021
@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from 08d6e08 to 5c8a41c Compare April 12, 2021 11:31
@frb121 frb121 marked this pull request as ready for review April 12, 2021 11:34
@frb121 frb121 self-assigned this Apr 12, 2021
@frb121 frb121 marked this pull request as draft April 12, 2021 12:13
@frb121 frb121 added the nobuild label Apr 12, 2021
@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from 5c8a41c to 26eef1b Compare April 20, 2021 09:55
@frb121 frb121 marked this pull request as ready for review April 20, 2021 09:56
@frb121 frb121 requested a review from pstorz April 20, 2021 09:56
@frb121 frb121 removed the nobuild label Apr 20, 2021
@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from 26eef1b to 7fcc043 Compare April 20, 2021 09:58
@frb121 frb121 changed the title systemtests: introduce ai-duplicate-job-cancel test dird: ignore duplicate job checking on virtual fulls started by consolidation Apr 20, 2021
@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from 40c2cdc to 1b0be26 Compare April 22, 2021 10:10
pstorz
pstorz requested changes Apr 23, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

The testname does not exactly say what it verifies, so that should be adapted.

@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from 1b0be26 to 1eb3a9a Compare April 23, 2021 11:48
@frb121
Copy link
Contributor Author

frb121 commented Apr 23, 2021

Made some notes in the documentation on how the Allow Duplicate Jobs directive behaves in case of generated virtual backups by a consolidate job. See additional commit 1eb3a9a.

frb121 and others added 3 commits April 23, 2021 14:00
@frb121
systemtests: introduce ai-consolidate-ignore-duplicate-job test
671c62c 
This test checks if we end up with a canceled virtual full after
consolidation while trying to override the allow duplicate job
directive from a jobdefs in the consolidation job resource.

The test fails if the virtual full is canceled.
@frb121
dird: ignore duplicate job checking on native virtual full backup
371c5b0 
Fixes #792: Unable to use "AllowDuplicateJobs=no" with AI/Consolidate
@frb121
Update CHANGELOG.md
93435b1
@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from 1eb3a9a to a6dc4eb Compare April 23, 2021 12:04
pstorz
pstorz requested changes Apr 26, 2021
View reviewed changes
@frb121 frb121 force-pushed the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch from a6dc4eb to de1a5e5 Compare April 26, 2021 11:16
pstorz
pstorz approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit bc79ef5 into master Apr 26, 2021
@pstorz pstorz deleted the dev/fbergkemper/master/s4147-allow-duplicate-jobs-limitation-ai branch April 26, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@frb121 frb121

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frb121 @pstorz