Fix #1257: Prune volume command may crash the director#546
Merged
arogge merged 2 commits intobareos:masterfrom Jun 29, 2020
Merged
Fix #1257: Prune volume command may crash the director#546arogge merged 2 commits intobareos:masterfrom
arogge merged 2 commits intobareos:masterfrom
Conversation
pstorz
approved these changes
Jun 25, 2020
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks correct, thanky you very much. Sorry for introducing this problem.
Member
Author
|
Nevermind, I was the one who didn't notice it during review. |
Issue bareos#1257: Prune volume command may crash the director The test now also runs manual pruning and checks that the job-message emitted contains the correct volume name.
Fixes bareos#1257: Prune volume command may crash the director Previously the mr->VolumeName to fill the %s in the Jmsg was missing.
0abc124 to
664cd2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test-case to the prune-volume systemtest that checks the broken behaviour. It also contains a fix for the issue.