Conversation
When multiple .bvfs_update operations were run simultaneously and both jobs have many common paths, it was possible that this caused unique constraint violation errors (PostgreSQL) or duplicate entry errors (MySQL/MariaDB). While this did not cause any functional problem, it could bloat logs with lots of error messages in some cases. This change adds an explicit exclusive write lock to prevent from such error messages.
arogge
requested changes
Jun 18, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
I could sleep a lot better if the transaction wasn't started and committed implicitly by the commands without the abstraction layer knowing what is going on.
Could we have StartTransaction() and EndTransaction() in the code and then just the lock and unlock queries in the actual query-files?
This will require a NO-OP query in case of PostgreSQL, but I think I'd still like that better.
arogge
approved these changes
Jun 22, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
After learning the hurdles of doing this right, I think it is OK to do it this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple .bvfs_update operations were run simultaneously and
both jobs have many common paths, it was possible that this caused
unique constraint violation errors (PostgreSQL) or duplicate entry
errors (MySQL/MariaDB). While this did not cause any functional
problem, it could bloat logs with lots of error messages in some
cases. This change adds an explicit exclusive write lock to prevent
from such error messages.