Merged
Conversation
The bareos-tray-monitor.desktop file tried to exec the traymonitor with the -c parameter to specify the config file. However, this config file is no longer shipped with Bareos, since 16.2.2. Also the parameter is not required at all, as the configuration default path is known to the traymonitor binary.
Replaced by 128x128 PNG file. Using XPM as pixmaps is deprecated and using a low resolution icon looks ugly on modern desktop environments.
Fixes #1195: Permissions of the configuration files in /etc/bareos/tray-monitor.d/
This configuration resources only refer to local daemons and each file should only be installed, if the corresponding daemon is installed. This partly reverts 15b1c84
118e236 to
cb8a7bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bareos-tray-monitor.desktop did contain the line
However, the tray-monitor.conf isn't packages any more with the standard Bareos Linux packages.
This results that the Bareos Tray Monitor isn't started by autostart as intended.
This PR fixes this problem and cleans up some other traymonitor related things.
Note that this problem might exist since Bareos 16.2.