Fix Segfault in SpoolDevice::~SpoolDevice()#535
Merged
arogge merged 3 commits intobareos:masterfrom Jun 9, 2020
Merged
Conversation
Previously the signal handler allocated memory by calling GetPoolMemory() indirectly via the BErrNo ctor. In case the signal handler was called while the mutex for pool memory was locked, the result was a deadlock. This patch removes the usage of BErrNo in favor of standard strerror() which avoids GetPoolMemory() and in turn fixed the deadlock.
Near the end of DespoolData() rdev->dev_name and rdev->errmsg are freed. However, the pointers are not set to nullptr, which leads to a double-free when the dtor runs. This patch removes the FreeMemory()/FreePoolMemory() calls and leaves cleaning to the dtor alone.
franku
approved these changes
Jun 3, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Looks good, ran systemtest successful on my laptop.
Thanks you found that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series of patches adds a new systemtest that runs a backup with data spooling enabled to show a crash in that configuration. It also fixes the crash triggered by the systemtest.
Last, but not least, it fixes a deadlock in signalhandler that surfaced during testing.