oVirt plugin: fix restore problem to local disk#534
Merged
Conversation
Fix local restore problem introduced with commit 1120208. During local restore, the restore is cancelled with a KeyError: File "BareosFdWrapper.py", line 66, in create_file return bareos_fd_plugin_object.create_file(context, restorepkt) File "BareosFdPluginOvirt.py", line 268, in create_file context, restorepkt.ofname File "BareosFdPluginOvirt.py", line 1521, in get_ovf_disk_alias_by_basename return self.ovf_disks_by_alias_and_fileref[relname]["disk-alias"] KeyError: ('testvm1_thin_cow-3b0d105b-0803-4964-be21-ede95153761c/524941fd-ef79-494f-9831-1d49cff9ed76',) The cause is that the disk alias filtering uses information that is not fetched from the oVirt Server during local install, as it is not contacted at all. During local install, no disks are filtered and every disk backed up will be restored. Fixes #1246: oVirt plugin fails to restore to local disk with KeyError
sduehr
approved these changes
May 29, 2020
Member
sduehr
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix local restore problem introduced with commit 1120208.
During local restore, the restore is cancelled with a KeyError:
KeyError: ('testvm1_thin_cow-3b0d105b-0803-4964-be21-ede95153761c/524941fd-ef79-494f-9831-1d49cff9ed76',)
The cause is that the disk alias filtering uses information that is not
fetched from the oVirt Server during local install, as it is not
contacted at all.
During local install, no disks are filtered and every disk backed up will be
restored.
Fixes #1246: oVirt plugin fails to restore to local disk with KeyError