python-plugins: improve statp handling in localfileset plugin#530
Merged
python-plugins: improve statp handling in localfileset plugin#530
Conversation
Contributor
|
Would change the first commit message to a smaller headline: python-plugins: improve statp handling in LocalFileset plugin
|
ebf30d3 to
3c6f954
Compare
- make own test for localfilest with rop - include weird files in test with disabled links - format pep8 / black - TODO: timestamp still not working for links (python 2 limitation in os.utime)
b915272 to
96fe6b5
Compare
96fe6b5 to
9433732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encodes filenames (string_escape) before sending to director, this way weird filenames will be restored correctly.
Also renamed exisiting systemtest python-fd-plugin-local-fileset-test to python-fd-plugin-local-fileset-rop-test and created a new test including weird-files.
Also added class variable and new method to LocalFilest to ease file-handling for derived classes, e.g. SplitJobs plugin, which is derived from this clas.