Fix bscan handling of restore object data#516
Merged
sduehr merged 1 commit intobareos:masterfrom May 18, 2020
sduehr:dev/sduehr/master/fix_bscan_restoreobjects
Merged
Fix bscan handling of restore object data#516sduehr merged 1 commit intobareos:masterfrom sduehr:dev/sduehr/master/fix_bscan_restoreobjects
sduehr merged 1 commit intobareos:masterfrom
sduehr:dev/sduehr/master/fix_bscan_restoreobjects
Conversation
When reading restore object data from a volume, bscan must set ObjectType to 25 (FT_RESTORE_FIRST). This affects all plugins that use restore objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading restore object data from a volume, bscan must set
ObjectType to 25 (FT_RESTORE_FIRST). This affects all plugins
that use restore objects.
I've noticed that the FileIndex column of the RestoreObject table does not get filled with sequential/unique values like it was after the original backup. However, this is obviously
irrelevant as the restore works successfully with this patch.