Added VirtualFull option to JobRun Form#508
Merged
frb121 merged 1 commit intobareos:masterfrom May 12, 2020
Merged
Conversation
Added VirtualFull option for manual defined Jobs. In my case, sometimes you have a Full Job and some Incremental ones and you just one to merge them into a new Virtual Full. From the UI it is really simple to do it if we add this option to the menu.
Contributor
|
Thanks for the PR, Alvaro. |
Contributor
|
Looks good. Useful for many others, I think. |
frb121
approved these changes
May 12, 2020
Contributor
|
Ok, here is just an idea if you would like to extend this a bit in a future PR. It would be great to have an additional form element (next pool) displayed but just in case you switched to a VirtualFull. The displayed form element (input select) should have the default Next Pool directive of the selected pool preselected but it should be possible to override it too. I think you get the idea. Going to merge this one now. Cheers, |
Contributor
Author
|
Great! I'm working on the changes you proposes. They make sense to me. |
Contributor
|
Nice, looking forward to it. By the way, if you like, join our bareos-devel mailing list which is always a good place to discuss Bareos development related stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added VirtualFull option for manual defined Jobs. In my case, sometimes you have a Full Job and some Incremental ones and you just one to merge them into a new Virtual Full. From the UI it is really simple to do it if we add this option to the menu.