Merged
Conversation
Don't provide an input select field when there is only one DIRD configured, instead automatically provide the configured DIRD as default and set the input field to read-only.
58121bb to
c8f3f9f
Compare
This commit adds a missing default value to a hidden form element. It fixes a possible login problem, which could occur when you send login form data before fetching package update information in the background finished with success or an error. Special thanks goes to Alvaro Flaño who reported the issue and also has put some effort into solving it.
Ensure everything is loaded before we retrieve package update information via Ajax.
Closed
franku
suggested changes
May 11, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Looks good, however I would remove the initializer from one positional argument because the code does not handle the null value.
franku
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.